Skip to content

Charset: Polyfill mb_ord() and mb_chr().#11965

Closed
dmsnell wants to merge 1 commit into
WordPress:trunkfrom
dmsnell:charset/polyfill-mb-ord-chr
Closed

Charset: Polyfill mb_ord() and mb_chr().#11965
dmsnell wants to merge 1 commit into
WordPress:trunkfrom
dmsnell:charset/polyfill-mb-ord-chr

Conversation

@dmsnell
Copy link
Copy Markdown
Member

@dmsnell dmsnell commented May 25, 2026

Trac ticket: Core-65342

See also Core-62172
Preparation for #11567

These functions are useful primitives but missing when the mbstring extension isn’t available. This patch adds polyfills for those few environments where this is the case so that WordPress code can unconditionally call them.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell dmsnell force-pushed the charset/polyfill-mb-ord-chr branch from 8acb4d1 to 199e564 Compare May 26, 2026 03:31
These functions are useful primitives but missing when the mbstring
extension isn’t available. This patch adds polyfills for those few
environments where this is the case so that WordPress code can
unconditionally call them.
@dmsnell dmsnell force-pushed the charset/polyfill-mb-ord-chr branch from 23f33d6 to 500e1f0 Compare May 28, 2026 01:19
pento pushed a commit that referenced this pull request May 28, 2026
These functions are useful primitives but missing when the mbstring
extension isn’t available. This patch adds polyfills for those few
environments where this is the case so that WordPress code can
unconditionally call them.

Developed in: #11965
Discussed in: https://core.trac.wordpress.org/ticket/65342

Fixes #65342.


git-svn-id: https://develop.svn.wordpress.org/trunk@62424 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62424
GitHub commit: 6782f0e

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this May 28, 2026
@dmsnell dmsnell deleted the charset/polyfill-mb-ord-chr branch May 28, 2026 01:55
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request May 28, 2026
These functions are useful primitives but missing when the mbstring
extension isn’t available. This patch adds polyfills for those few
environments where this is the case so that WordPress code can
unconditionally call them.

Developed in: WordPress/wordpress-develop#11965
Discussed in: https://core.trac.wordpress.org/ticket/65342

Fixes #65342.

Built from https://develop.svn.wordpress.org/trunk@62424


git-svn-id: http://core.svn.wordpress.org/trunk@61705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant